Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing native type-hints #37

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Conversation

boesing
Copy link
Member

@boesing boesing commented Aug 26, 2023

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no

Description

This patch provides native type-hints to any class' properties and methods.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
Copy link
Member Author

boesing commented Aug 26, 2023

Psalm phpunit plugin does not yet support v10 attributes.
I do not have time to actually implement it and thus, putting those errors to the baseline for now.

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: good improvement.

Merge at your own discretion.

psalm.xml.dist Show resolved Hide resolved
@boesing boesing merged commit 287d7cc into laminas:3.0.x Aug 27, 2023
@boesing boesing deleted the qa/type-hints branch August 27, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants