Update to support PHP 8.1 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de>
Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de>
Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de>
Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de>
…p math extension found Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de>
Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de>
pascalheidmann
force-pushed
the
php8.1
branch
from
df2ab4a to
a2bf493
Compare
Ocramius
requested changes
Oct 21, 2021
|
@pascalheidmann This package is security-only maintenance mode therefore the support for PHP 8.1 is good, but any breaking changes must be omitted. |
Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de>
Ocramius
requested changes
Oct 21, 2021
Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de>
Ocramius
reviewed
Oct 23, 2021
Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de>
Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de>
Ocramius
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR
laminas/laminas-serializerruns under PHP 8.1.It updates several dependencies to allow compatibility especially with
laminas/laminas-coding-style. This results in quite a few changes code style improvements and better code quality.As this PR also adds return types & type hints to several classes this might be considered as a breaking change. Those changes are also listed in the newly addedCHANGELOG.md.BCs like return types & type hints for library sources are not part anymore (I left those in tests as those shouldn't be a concern of changes of signatures).