Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consumer type inference with InputFilter templates #91

Merged
merged 12 commits into from
Jul 14, 2023
Merged

Improve consumer type inference with InputFilter templates #91

merged 12 commits into from
Jul 14, 2023

Commits on Jul 14, 2023

  1. Improve consumer type inference with InputFilter templates 

    Adds a template to InputFilterInterface to define the array shape of filtered values

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cfa8907 View commit details
    Browse the repository at this point in the history

  2. fix: Inputs and InputFilters cannot be merged 

    Solves a type collision where `add` accepts InputInterface or InputFilterInterface but does not check that the merge targets are compatible.

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    d79f252 View commit details
    Browse the repository at this point in the history

  3. Remove the 'default' types for TFilteredValues 

    Psalm does not really work on the basis of template defaults, they are a restriction. This causes problems with nested input filters and collections

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    9e83e6b View commit details
    Browse the repository at this point in the history

  4. Minor psalm fixes 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    948eede View commit details
    Browse the repository at this point in the history

  5. Input names can feasibly be an array-key type and are integers for co… 

    …llections

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    d1f875b View commit details
    Browse the repository at this point in the history

  6. Add a collection input filter to static analysis tests 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    3978faf View commit details
    Browse the repository at this point in the history

  7. Clarify existing behaviour with an empty string for an input name 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    4b52ac8 View commit details
    Browse the repository at this point in the history

  8. Additional tests to cover input merging behaviour 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    410e504 View commit details
    Browse the repository at this point in the history

  9. Refresh baseline 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    50a46ec View commit details
    Browse the repository at this point in the history

  10. Bump filter and validator minimum versions where the filter chain and… 

    … validator chain became iterable

Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    645131e View commit details
    Browse the repository at this point in the history

  11. Add cookbook documentation on using array shapes with InputFilter 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    df3a17d View commit details
    Browse the repository at this point in the history

  12. qa: remove trailing spaces in README 

    Signed-off-by: George Steel <george@net-glue.co.uk>
    @gsteel
    gsteel committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    4af687c View commit details
    Browse the repository at this point in the history