Psalm integration

[boesing]

Feature Request

Q	A
QA	yes

Summary

As decided during the Technical-Steering-Committee Meeting on August 3rd, 2020, Laminas wants to implement vimeo/psalm in all packages.

Implementing psalm is quite easy.

Required

• Create a psalm.xml in the project root
• Copy and paste the contents from this psalm.xml.dist
• Run $ composer require --dev vimeo/psalm
• Run $ vendor/bin/psalm --set-baseline=psalm-baseline.xml
• Add a composer script static-analysis with the command psalm --shepherd --stats
• Add a new line to script: in .travis.yml: - if [[ $TEST_COVERAGE == 'true' ]]; then composer static-analysis ; fi
• Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

Optional

• Fix as many psalm errors as possible.

[tux-rampage]

@boesing composer require vimeo/psalm would add it as a runtime dependency. Shouldn't this be composer require --dev vimeo/psalm In general I'd even prefer composer global require vimeo/psalm locally and in CI to not mess with the dependency tree. Unlike PHPstan, psalm is not distributed with isolated dependencies.

[michalbundyra]

@tux-rampage yes, it should be --dev