Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly types $event property as ?EventFeature\TableGatewayEvent instead of null #304

Closed
wants to merge 3 commits into from
Closed

Correctly types $event property as ?EventFeature\TableGatewayEvent instead of null #304

wants to merge 3 commits into from

Conversation

tyrsson
Copy link
Contributor

@tyrsson tyrsson commented Apr 1, 2024

Correctly types $event property to EventInterface instead of just null

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Correctly types $event property to EventInterface instead of just null
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@@ -23,7 +24,7 @@ class EventFeature extends AbstractFeature implements
/** @var EventManagerInterface */
protected $eventManager;

/** @var null */
/** @var ?EventInterface */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EventFeature\TableGatewayEvent, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I suppose it should be limited to TableGatewayEvent. Im currently adding a custom feature is when I noticed it. But since this is focused on the EventFeature it should be the narrower TableGatewayEvent. Will update here in just a second.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson tyrsson changed the title Correctly types $event property as ?EventInterface instead of null Correctly types $event property as ?EventFeature\TableGatewayEvent instead of null Apr 1, 2024
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tyrsson

@Ocramius
Copy link
Member

Ocramius commented Apr 1, 2024

Sigh, MSSQL is broken again 🙄

@Ocramius Ocramius added this to the 2.16.4 milestone Apr 1, 2024
@Ocramius Ocramius changed the base branch from 2.16.x to 2.20.x April 1, 2024 20:32
@Ocramius Ocramius modified the milestones: 2.16.4, 2.20.0 Apr 1, 2024
@Ocramius
Copy link
Member

Ocramius commented Apr 1, 2024

@tyrsson this needs a rebase on 2.20.x

@tyrsson tyrsson closed this by deleting the head repository Apr 2, 2024
@Ocramius Ocramius added Duplicate This issue or pull request already exists and removed Help Wanted labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Duplicate This issue or pull request already exists Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants