Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/246 "and" and "or" methods #301

Open
wants to merge 5 commits into
base: 2.20.x
Choose a base branch
from

Conversation

LikeAJohny
Copy link

@LikeAJohny LikeAJohny commented Feb 20, 2024

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes?

Description

I'm simply adding methods for "and" and "or" to the Predicate class as proposed in #246.

Since the library is targeting PHP 8.1 onwards I've made some version specific type annotations as well as converting a switch to a match expression.

LikeAJohny and others added 4 commits February 20, 2024 23:29
Signed-off-by: LikeAJohny <LikeAJohny@users.noreply.github.com>
Signed-off-by: LikeAJohny <LikeAJohny@users.noreply.github.com>
Signed-off-by: LikeAJohny <LikeAJohny@users.noreply.github.com>
Signed-off-by: LikeAJohny <LikeAJohny@users.noreply.github.com>
@LikeAJohny LikeAJohny changed the base branch from dev-3.0.0 to 2.20.x February 20, 2024 22:37
@LikeAJohny LikeAJohny marked this pull request as ready for review February 20, 2024 22:37
Signed-off-by: LikeAJohny <LikeAJohny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant