Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select::having() can get an Having as parameter #296

Closed
panvid opened this issue Nov 28, 2023 · 1 comment
Closed

Select::having() can get an Having as parameter #296

panvid opened this issue Nov 28, 2023 · 1 comment
Labels
Bug Something isn't working

Comments

@panvid
Copy link

panvid commented Nov 28, 2023

This is only a phpDoc problem:

https://github.com/laminas/laminas-db/blob/2.19.x/src/Sql/Select.php#L305C1-L305C1

Select::having($predicate) could also get an Having as $predicate parameter. This PhpDoc does not say this.
@panvid panvid added the Bug Something isn't working label Nov 28, 2023
@rvm-peercode
Copy link
Contributor

PR: #295

rvm-peercode added a commit to rvm-peercode/laminas-db that referenced this issue Dec 11, 2023
@rvm-peercode
Update docblock of having()
3339054 
Fixes: laminas#296

Signed-off-by: Roel van Meer <roel.van.meer@peercode.nl>
@Xerkus Xerkus closed this as completed in 782890b Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panvid @rvm-peercode