Skip to content

Add a CI Workflow for Rector during installation - #24

Merged
gsteel merged 3 commits into
laminas:1.0.xfrom
gsteel:rector-ci
Oct 7, 2026
Merged

gsteel merged 3 commits into
laminas:1.0.xfrom
gsteel:rector-ci

Conversation

@gsteel

@gsteel gsteel commented Oct 7, 2026

Copy link
Copy Markdown
Member
  • Installs a GHA workflow for rector
  • Adds features to sync required PHP extensions to GHA workflows
  • Updates the 8.6 migration so that all workflows are scanned for an update to the default_php

This patch is done onto of #23, so that will need merging first.

@gsteel gsteel added this to the 1.0.0 milestone Oct 7, 2026
@gsteel
gsteel requested a review from a team October 7, 2026 15:34

@froschdesign froschdesign left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Comment on lines +1 to +2
variant = "strict"
[entries]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#
# Project Specific Mago Configuration
#
extends = "vendor/laminas/internal-tooling/mago/defaults.toml"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gsteel added 3 commits October 7, 2026 21:08
Also makes sure that we iterate over all GHA workflows updating the `default_php` environment variable when it is set.

Signed-off-by: George Steel <george@net-glue.co.uk>
…ed PHP extensions

Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel self-assigned this Oct 7, 2026
@gsteel
gsteel merged commit d282a7b into laminas:1.0.x Oct 7, 2026
17 checks passed
@gsteel
gsteel deleted the rector-ci branch October 7, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants