Repository navigation
Makefile Improvements - #17
Merged
Merged
Conversation
froschdesign
approved these changes
Oct 7, 2026
froschdesign
left a comment
froschdesign
left a comment
Member
There was a problem hiding this comment.
The conflict must be solved but everything else looks good and is understandable!
Instead of using `awk` to automatically collect help text from targets, a macro is defined and used per job to aggregate help text into a variable. The `help` target then becomes `echo $(HELP)`. The reason for this which is also addressed in this patch is that we don't want to see a list of targets that are not relevant to current project, i.e. we don't want to see `psalm` targets when `psalm` is not being used. `awk` can't handle this conditional inclusion, hence the `MK_HELP` macro. Signed-off-by: George Steel <george@net-glue.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using
awkto automatically collect help text from targets, a macro is defined and used per job to aggregate help text into a variable.The
helptarget then becomesecho $(HELP).The reason for this which is also addressed in this patch is that we don't want to see a list of targets that are not relevant to current project, i.e. we don't want to see
psalmtargets whenpsalmis not being used.awkcan't handle this conditional inclusion, hence theMK_HELPmacro.