Added possibility to pass command line arguments #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Mar 17, 2017
batchUpload.sh
Outdated
|
|
||
| subdomain='' | ||
| email='' | ||
| password='' |
There was a problem hiding this comment.
I can foresee someone editing this file and accidentally committing it exposing their details.
Perhaps call this file something like batchUploadExample.sh, ignore batchUpload.sh from Git, and instruct people to copy the former to the latter and edit that.
There was a problem hiding this comment.
Makes sense. I have made the change and pushed it.
|
Looking good, thanks @bchalls . Merging! |
jordan8037310
added a commit
to jordan8037310/emojipacks
that referenced
this pull request
Jun 14, 2017
* commit '8f20d6d538ad6b58b7da085cef43237c73d928d8': (49 commits) Revert "created an all emoji file (lambtron#118)" (lambtron#119) created an all emoji file (lambtron#118) Added prefix to occupy emoji. [lambtron#116] (lambtron#116) Adds Political Pack of Emojis (lambtron#115) bump patch fix upload slackmoji yaml file add some more beasts to the Animals pack including new emoji :columbian-mammoth: 🦤 :emu: :platypus: :sabre-tooth-tiger: :wildebeest: :wooly-mammoth: 🦓 :arctic-fox: :desert-fox: :festive-reindeer: :great-auk: :great-owl: :hawk: :moa: 🫎 :reindeer-crash: :reindeer-harness: :beluga-whale: :blue-whale: :grey-seal: :humpback-whale: :killer-whale: :narwhal2: 🦝 :robot-dog: :robot-scorpion: :robot-shark: :coyote: (lambtron#111) Unicorn Pack (lambtron#110) New Weapons Pack. (lambtron#108) fix link (lambtron#109) Add gamedevmoji (lambtron#107) Allow emoji aliases to be created from emojipacks (lambtron#106) image-checker.py: Fix python 3 compatibility (lambtron#105) Add Shiba emojipack (lambtron#103) Add Marvel Avengers emojipack (lambtron#101) Added hamsterdance emojipack (lambtron#99) Version bump. Removed --harmony option from shebang (lambtron#96) Fixes broken links in skype.yaml v2 (lambtron#93) Added possibility to pass command line arguments (lambtron#91) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility to pass command line arguments to allow for batch yaml file upload