Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pack with German states' (Bundesländer) coats of arms #137

Merged
merged 2 commits into from
Oct 22, 2017

Conversation

pbock
Copy link
Contributor

@pbock pbock commented Oct 21, 2017

This adds a pack with 16 custom emoji, one for each of Germany's states (Bundesländer).

They use the official codes as part of their name, with the full name in German and common abbreviations as aliases, so Nordrhein-Westfalen is :de-nw: and has :nordrhein-westfalen: and :nrw: as aliases.

@hugovk
Copy link
Collaborator

hugovk commented Oct 21, 2017

There's an error on the CI:

Found 1 errors in packs/german-states.yaml
Error: custom emoji names can only contain lower case letters, numbers, dashes and underscores: de-nw - nordrhein-westfalen - nrw

Should this:

  - name: de-nw
      - nordrhein-westfalen
      - nrw

Be something like this?

  - name: de-nw
    aliases:
      - nordrhein-westfalen
      - nrw

@pbock
Copy link
Contributor Author

pbock commented Oct 22, 2017

Ah, indeed it should, thanks for brining this to my attention.

I hadn't even noticed that that emoji had failed to upload. I guess I didn't spot the error message in between the rest of the output.

@pbock
Copy link
Contributor Author

pbock commented Oct 22, 2017

Aaaaand… it's still failing, but this time it's due to a failing request in slackmojis-pokemon.yaml:

Found 1 errors in packs/slackmojis-pokemon.yaml
Error: cannot fetch image: http://emojis.slackmojis.com/emojis/images/1450735463/235/ditto.png (Forbidden)

…

Found 1 total errors and 1071 total warnings
The command "python test/image-checker.py --resize "packs/*.yaml"" exited with 1.

@hugovk
Copy link
Collaborator

hugovk commented Oct 22, 2017

Want to make a new PR to remove or replace the broken image? Thanks!

@hugovk
Copy link
Collaborator

hugovk commented Oct 22, 2017

I've made a PR here: #139

@zachfeldman zachfeldman reopened this Oct 22, 2017
@zachfeldman zachfeldman merged commit ddc6ca2 into lambtron:master Oct 22, 2017
@pbock pbock deleted the patch-1 branch October 22, 2017 19:59
camalot added a commit to bit13labs/emojipacks that referenced this pull request Feb 3, 2018
* 'master' of ssh://github.com/lambtron/emojipacks: (30 commits)
  Added export json conversion script to easily transfer emojis between slacks (lambtron#141)
  introducing pumpkinparrot and angelparrot (lambtron#140)
  CI: Only print summary if errors (lambtron#138)
  Add pack with German states' (Bundesländer) coats of arms (lambtron#137)
  Fix pokemon to fix CI (lambtron#139)
  five new parrots (lambtron#136)
  add luckyparrot and rotatingparrot (lambtron#133)
  Delete hipchat.yaml (lambtron#135)
  Update README.md with 2FA (lambtron#132)
  Added in ryangoslingparrot and tacoparrot (lambtron#131)
  Add Slackmoji prefixes (lambtron#127)
  added 11 new parrots (lambtron#128)
  Add Script to Update emojis from Slackmoji.com (lambtron#123)
  Updated file extension to fit with convention (lambtron#124)
  Add AWS Simple icons (lambtron#120)
  Update Finland pack with new emoji (lambtron#121)
  Revert "created an all emoji file (lambtron#118)" (lambtron#119)
  created an all emoji file (lambtron#118)
  Added prefix to occupy emoji. [lambtron#116] (lambtron#116)
  Adds Political Pack of Emojis (lambtron#115)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants