clj-kondo fails on o/defstyled

[credmp]

Thanks for the great package, really love it. clj-kondo shows it a little less love though.

I copied over the clj-kondo config from the repository, which removes a lot of errors already, however this snippet:

(ns comicstash.html.dashboard
  (:require
   [lambdaisland.ornament :as o]))

(o/defstyled collection-section :section
  :view-section :active :fade-in)

so, a simple defstyled, will generate a namespace level error saying:

error: Can't parse ./src/clj/comicstash/html/dashboard.clj, java.lang.Boolean cannot be cast to clojure.lang.Associative

and as a result the styles defined in the file are not resolved. Any help tracking down the reason for the error is appreciated, My guess is that it is in the ornament.clj in the clj-kondo hooks, but I have 0 experience in this domain.

[humorless]

Hello @credmp,

Thank you for letting me know that there are people like me love to make clj-kondo working with ornament. (I made this almost years ago. Seldom heard people using it.)

It seems that the problem is from the this line
https://github.com/lambdaisland/ornament/blob/main/.clj-kondo/hooks/ornament.clj#L42

If I change it to

   ;; nil node
      {:node node})))

The namespace level error will disappear, but other error will show up. (Well, will need more research.)

[humorless]

Hello @credmp,

It seems that the new hook implementation solved the bug.

(ns hooks.ornament
  (:require [clj-kondo.hooks-api :as api]))

(defn defstyled [{:keys [node]}]
  (let [[class-name html-tag & more] (rest (:children node))
        _ (when-not (and (api/token-node? class-name)
                         (simple-symbol? (api/sexpr class-name)))
            (api/reg-finding! {:row (:row (meta class-name))
                               :col (:col (meta class-name))
                               :message "Style name must be a symbol"
                               :type :lambdaisland.ornament/invalid-syntax}))
        ; _ (prn :class-name class-name)
        _ (when-not (api/keyword-node? html-tag)
            (api/reg-finding! {:row (:row (meta html-tag))
                               :col (:col (meta html-tag))
                               :message "Html-tag must be a keyword"
                               :type :lambdaisland.ornament/invalid-syntax}))
        ; _ (prn :html-tag html-tag)
        ; _ (prn :more more)
        fn-tag (first (drop-while (fn [x]
                                    (or (api/keyword-node? x)
                                        (api/map-node? x)
                                        (api/vector-node? x)))
                                  more))
        _ (prn :fn-tag fn-tag)
        _ (when (or (api/list-node? fn-tag)
                    (nil? fn-tag))
            (api/reg-finding! {:row (:row (meta fn-tag))
                               :col (:col (meta fn-tag))
                               :message "fn-tag must be at least a list or nil"
                               :type :lambdaisland.ornament/invalid-syntax}))
        def-class-form (api/list-node
                        (list (api/token-node 'def)
                              class-name
                              (api/token-node 'nil)))]
    (if (api/list-node? fn-tag)
      (let [[binding-vec & body] (:children fn-tag)
            new-node (api/list-node
                      (list*
                       (api/token-node 'fn)
                       binding-vec
                       body))]
        (prn :new-node (api/sexpr new-node))
        {:node new-node})
     ;; nil node
      {:node def-class-form})))

[credmp]

Yes! That works great, thank you so much.

It is very nice that the project now only has real issue lighting up flycheck :)

Thanks again for taking the time to fix it, I will close the issue.