Skip to content

zksolc compiler integration (MVP) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
May 22, 2023
Merged

Conversation

mationorato
Copy link
Collaborator

@mationorato mationorato commented May 15, 2023

The MVP consists of a minimal implementation that lets a developer compile a project with API methods and manually with the CLI for later deployment.

We'll write down some documentation explaining what is missing for the compiler to be fully integrated.

@IAvecilla IAvecilla marked this pull request as draft May 15, 2023 23:25
@ilitteri ilitteri changed the title [WIP] zksolc compiler integration [WIP] zksolc compiler integration MVP May 17, 2023
@ilitteri ilitteri changed the title [WIP] zksolc compiler integration (MVP) [zksolc compiler integration (MVP) May 17, 2023
@ilitteri ilitteri marked this pull request as ready for review May 17, 2023 22:08
@ilitteri ilitteri changed the title [zksolc compiler integration (MVP) zksolc compiler integration (MVP) May 17, 2023
@mationorato mationorato linked an issue May 18, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@89798af). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   17.48%           
=======================================
  Files           ?       15           
  Lines           ?      286           
  Branches        ?        0           
=======================================
  Hits            ?       50           
  Misses          ?      236           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

IAvecilla and others added 2 commits May 19, 2023 14:04
…ethods (#8)

* Add `async-trait` dep

* Add `ZKSProvider` initial implementation

* Add `Fee` type

* Add `zks_provider` module to `lib.rs`

* cargo fmt

* Add implementation for get paymaster request (#10)

* Fix `pay` cmd

* Add `L2_CHAIN_ID`

* `cargo fmt`

---------

Co-authored-by: Nacho Avecilla <nachoavecilla@gmail.com>
@ilitteri ilitteri enabled auto-merge (squash) May 19, 2023 20:06
@ilitteri ilitteri disabled auto-merge May 19, 2023 20:06
Copy link
Collaborator

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mationorato mationorato merged commit 7b415b9 into main May 22, 2023
@mationorato mationorato deleted the zksolc_compiler_integration branch May 22, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zksolc compilation
5 participants