Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eigenDA proxy to docker #258

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Conversation

gianbelinche
Copy link

@gianbelinche gianbelinche commented Sep 11, 2024

What ❔

This PR adds eigenDA proxy to docker initialization
Adds API_NODE_URL env variable to .toml in order to not need to run export EIGEN_DA_CLIENT_API_NODE_URL=http://127.0.0.1:3100
Adds a --da-eigen flag to zkserver, now you can run zk server --da-eigen instead of running cargo run --bin zksync_server --features da-eigen, the first time you need to run

cd infrastructure/zk
yarn build

In order to re-build the zk tool (maybe you can just run zk, i'm not sure)

Closes https://github.com/lambdaclass/hyperchain-da-eigenda/issues/2

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

Copy link

github-actions bot commented Sep 11, 2024

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

No release type found in pull request title "Add eigenDA proxy to docker". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@gianbelinche gianbelinche marked this pull request as ready for review September 12, 2024 13:53
Copy link

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gianbelinche gianbelinche merged commit 69ea100 into eigen-implementation Sep 13, 2024
8 of 49 checks passed
@gianbelinche gianbelinche deleted the proxy-docker branch September 13, 2024 15:12
juan518munoz pushed a commit that referenced this pull request Sep 17, 2024
* Add proxy to docker

* Add api_node_url to toml initialization

* Add eigenda flag to zk server

* Revert "Add eigenda flag to zk server"

This reverts commit 081cff6.

* Update submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants