Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add reverted transactions #813

Merged
merged 26 commits into from
Jul 17, 2023
Merged

Add reverted transactions #813

merged 26 commits into from
Jul 17, 2023

Conversation

matias-gonz
Copy link
Contributor

No description provided.

@matias-gonz matias-gonz self-assigned this Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #813 (91fef34) into main (4b90ba8) will decrease coverage by 0.07%.
The diff coverage is 90.20%.

❗ Current head 91fef34 differs from pull request most recent head 9050219. Consider uploading reports for the commit 9050219 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
- Coverage   91.84%   91.78%   -0.07%     
==========================================
  Files          54       54              
  Lines       12756    12885     +129     
==========================================
+ Hits        11716    11826     +110     
- Misses       1040     1059      +19     
Impacted Files Coverage Δ
src/state/cached_state.rs 89.55% <68.88%> (-3.80%) ⬇️
src/transaction/l1_handler.rs 97.17% <84.61%> (+0.02%) ⬆️
src/lib.rs 98.73% <89.47%> (+<0.01%) ⬆️
src/syscalls/business_logic_syscall_handler.rs 77.95% <91.30%> (+0.38%) ⬆️
src/transaction/deploy_account.rs 89.39% <93.10%> (-0.32%) ⬇️
src/transaction/declare_v2.rs 84.21% <93.75%> (+0.05%) ⬆️
src/execution/execution_entry_point.rs 97.27% <98.59%> (-0.11%) ⬇️
src/execution/mod.rs 97.57% <100.00%> (+0.01%) ⬆️
src/state/contract_storage_state.rs 95.45% <100.00%> (ø)
src/state/in_memory_state_reader.rs 90.69% <100.00%> (ø)
... and 14 more

... and 1 file with indirect coverage changes

@matias-gonz matias-gonz marked this pull request as ready for review July 13, 2023 22:31
@matias-gonz matias-gonz requested a review from Oppen July 14, 2023 16:27
@matias-gonz
Copy link
Contributor Author

Nothing is done with the reverted transactions because the real usage is implemented in: #787

Copy link
Collaborator

@SantiagoPittella SantiagoPittella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment but looks good.

@juanbono juanbono added this pull request to the merge queue Jul 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2023
@matias-gonz matias-gonz enabled auto-merge July 17, 2023 15:43
@matias-gonz matias-gonz added this pull request to the merge queue Jul 17, 2023
Merged via the queue into main with commit 8809ba0 Jul 17, 2023
@xqft xqft deleted the add_reverted_transactions branch July 17, 2023 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants