Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Check casm compilation #797

Closed
wants to merge 12 commits into from
Closed

Check casm compilation #797

wants to merge 12 commits into from

Conversation

mmsc2
Copy link
Contributor

@mmsc2 mmsc2 commented Jul 7, 2023

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #797 (b690a46) into main (f62e42e) will decrease coverage by 0.43%.
The diff coverage is 28.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
- Coverage   93.17%   92.74%   -0.43%     
==========================================
  Files          52       52              
  Lines       12127    12179      +52     
==========================================
- Hits        11299    11296       -3     
- Misses        828      883      +55     
Impacted Files Coverage Δ
src/transaction/declare_v2.rs 72.47% <28.81%> (-14.80%) ⬇️

Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me but let's check how to calculate the compiled_contract class hash to validate that

Copy link
Collaborator

@SantiagoPittella SantiagoPittella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm re-doing this issue in another branch.
#819

@juanbono juanbono closed this Jul 17, 2023
@juanbono juanbono deleted the FixCompilingInStarknet branch July 31, 2023 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants