Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Represent version as a felt252 #615

Merged
merged 16 commits into from
Jun 14, 2023
Merged

Conversation

mfachal
Copy link
Contributor

@mfachal mfachal commented Jun 7, 2023

Linked to issue #356 and related to PR 372

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #615 (b56ee56) into main (f81fd3c) will increase coverage by 0.00%.
The diff coverage is 96.34%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files          50       50           
  Lines       10330    10331    +1     
=======================================
+ Hits         9523     9524    +1     
  Misses        807      807           
Impacted Files Coverage Δ
src/business_logic/transaction/declare_v2.rs 84.83% <66.66%> (ø)
src/core/transaction_hash/mod.rs 78.40% <87.50%> (ø)
src/business_logic/execution/mod.rs 97.57% <100.00%> (ø)
src/business_logic/transaction/declare.rs 98.73% <100.00%> (ø)
src/business_logic/transaction/deploy.rs 98.63% <100.00%> (ø)
src/business_logic/transaction/deploy_account.rs 97.86% <100.00%> (ø)
src/business_logic/transaction/invoke_function.rs 99.27% <100.00%> (+<0.01%) ⬆️
src/lib.rs 92.13% <100.00%> (ø)
src/syscalls/business_logic_syscall_handler.rs 79.58% <100.00%> (ø)
src/syscalls/deprecated_syscall_handler.rs 98.97% <100.00%> (ø)
... and 1 more

@juanbono juanbono added this pull request to the merge queue Jun 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 12, 2023
@mmsc2 mmsc2 added this pull request to the merge queue Jun 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2023
@matias-gonz matias-gonz added this pull request to the merge queue Jun 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2023
@mmsc2 mmsc2 added this pull request to the merge queue Jun 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2023
@matias-gonz matias-gonz enabled auto-merge June 13, 2023 20:20
@matias-gonz matias-gonz added this pull request to the merge queue Jun 14, 2023
Merged via the queue into main with commit 64e9375 Jun 14, 2023
@juanbono juanbono deleted the transaction-version-is-felt branch June 14, 2023 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants