This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanbono
suggested changes
Jun 7, 2023
src/business_logic/state/mod.rs
Outdated
@@ -3,6 +3,9 @@ pub(crate) mod contract_storage_state; | |||
pub mod state_api; | |||
pub mod state_cache; | |||
|
|||
pub mod in_memory_state_reader; | |||
pub mod structs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move the StateDiff and the ExecutionResourcesManager to different files to avoid having a structs::
prefix? Or move them to state/mod.rs so we can import them directly from state
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
=======================================
Coverage 89.99% 89.99%
=======================================
Files 50 49 -1
Lines 10043 10043
=======================================
Hits 9038 9038
Misses 1005 1005
|
juanbono
approved these changes
Jun 7, 2023
mmsc2
approved these changes
Jun 8, 2023
…rknet_in_rust into move-fact-state-to-state
…ove-fact-state-to-state
…ove-fact-state-to-state
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #601