Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Refactor fact_state #603

Merged
merged 14 commits into from
Jun 12, 2023
Merged

Refactor fact_state #603

merged 14 commits into from
Jun 12, 2023

Conversation

mfachal
Copy link
Contributor

@mfachal mfachal commented Jun 6, 2023

Linked to #601

@@ -3,6 +3,9 @@ pub(crate) mod contract_storage_state;
pub mod state_api;
pub mod state_cache;

pub mod in_memory_state_reader;
pub mod structs;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move the StateDiff and the ExecutionResourcesManager to different files to avoid having a structs:: prefix? Or move them to state/mod.rs so we can import them directly from state

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #603 (9bb3ff5) into main (e42da3d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files          50       49    -1     
  Lines       10043    10043           
=======================================
  Hits         9038     9038           
  Misses       1005     1005           
Impacted Files Coverage Δ
.../business_logic/execution/execution_entry_point.rs 96.83% <ø> (ø)
src/business_logic/state/cached_state.rs 93.27% <ø> (ø)
src/business_logic/state/in_memory_state_reader.rs 91.11% <ø> (ø)
src/business_logic/transaction/fee.rs 98.76% <ø> (ø)
...ness_logic/transaction/objects/internal_declare.rs 98.73% <ø> (ø)
...iness_logic/transaction/objects/internal_deploy.rs 98.63% <ø> (ø)
...gic/transaction/objects/internal_deploy_account.rs 97.86% <ø> (ø)
...ic/transaction/objects/internal_invoke_function.rs 98.94% <ø> (ø)
...usiness_logic/transaction/objects/v2/declare_v2.rs 84.71% <ø> (ø)
src/runner/mod.rs 80.09% <ø> (ø)
... and 7 more

@juanbono juanbono added this pull request to the merge queue Jun 12, 2023
Merged via the queue into main with commit 286e199 Jun 12, 2023
@juanbono juanbono deleted the move-fact-state-to-state branch June 14, 2023 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants