This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Move CLI to crate and remove actix-web from deps #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanbono
reviewed
May 31, 2023
cli/Cargo.toml
Outdated
| mimalloc = { version = "0.1.29", default-features = false, optional = true } | ||
| hex = "0.4.3" | ||
| cargo-llvm-cov = "0.5.14" | ||
| starknet-rs = {path = "../"} |
There was a problem hiding this comment.
I think you should not use a relative path to specify the dependency but the github repository
juanbono
suggested changes
May 31, 2023
cli/Cargo.toml
Outdated
| serde = { version = "1.0.152", features = ["derive"] } | ||
| serde_json = { version = "1.0", features = ["arbitrary_precision"] } | ||
| sha3 = "0.10.1" | ||
| starknet_api = { git = "https://github.com/lambdaclass/starknet-api", rev="b29d881", features = [ |
There was a problem hiding this comment.
Instead of using the lambdaclass fork of this lib you should use the one from https://github.com/starkware-libs/starknet-api
juanbono
approved these changes
Jun 1, 2023
fmoletta
approved these changes
Jun 1, 2023
juanbono
suggested changes
Jun 2, 2023
Cargo.toml
Outdated
| @@ -25,7 +25,6 @@ starknet_api = { git = "https://github.com/starkware-libs/starknet-api", rev="a8 | |||
| starknet-crypto = "0.4.3" | |||
| thiserror = "1.0.32" | |||
| clap = { version = "4.1.8", features = ["derive"] } | |||
There was a problem hiding this comment.
you should remove clap too
juanbono
approved these changes
Jun 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #536