Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Use explicit transaction version in InternalInvokeFunction::new #549

Conversation

kkovaacs
Copy link
Contributor

Instead of always constructing InvokeFunction transactions as version 1, this change adds an explicit version argument to new() -- just like we already have for other transaction types.

Instead of always constructing InvokeFunction transactions as version 1,
this change adds an explicit version argument to `new()` -- just like we
already have for other transaction types.
@codecov-commenter
Copy link

Codecov Report

Merging #549 (38488db) into main (3b5fce6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   89.75%   89.75%           
=======================================
  Files          53       53           
  Lines        9919     9921    +2     
=======================================
+ Hits         8903     8905    +2     
  Misses       1016     1016           
Impacted Files Coverage Δ
...ic/transaction/objects/internal_invoke_function.rs 98.94% <100.00%> (ø)
src/core/syscalls/deprecated_syscall_handler.rs 98.96% <100.00%> (+<0.01%) ⬆️
src/testing/starknet_state.rs 96.77% <100.00%> (+<0.01%) ⬆️

@juanbono juanbono added this pull request to the merge queue May 31, 2023
Merged via the queue into lambdaclass:main with commit f1ca441 May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants