This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Add flamegraph target to Makefile #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 73.47% 70.93% -2.54%
==========================================
Files 39 40 +1
Lines 2601 2694 +93
==========================================
Hits 1911 1911
- Misses 690 783 +93
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- don't use test harness
juanbono
approved these changes
Mar 20, 2023
Oppen
reviewed
Mar 20, 2023
Comment on lines
+26
to
+29
| static ref CONTRACT_CLASS: ContractClass = ContractClass::try_from(PathBuf::from( | ||
| "starknet_programs/account_without_validation.json", | ||
| )) | ||
| .unwrap(); |
There was a problem hiding this comment.
Is there any way to build the ContractClass from bytes? In that case you could use include_bytes! instead of creating a path that needs to be read from.
There was a problem hiding this comment.
The GH workflow that runs clippy doesn't install deps and so cannot compile the cairo programs. I'll revert this change.
Oppen
approved these changes
Mar 21, 2023
To do so, had to add compile-starknet to Makefile target dependencies.
This reverts commit 10f9c96.
igamigo
pushed a commit
that referenced
this pull request
Mar 21, 2023
* Add flamegraph target to Makefile * Add dependency to target * Fix: activate venv before compiling contracts * Rename benches * Add declare test - don't use test harness * Clone elements outside `scope` * Appease clippy * Add deploy test * Reduce run count * Fix: invert guard in `handle_empty_constructor` * Use correct class_hash in test * Add invoke flamegraph * Pin cargo-flamegraph version * Add instructions to README * Remove unnecessary clone * Add ContractClass with include_str! To do so, had to add compile-starknet to Makefile target dependencies. * Revert "Add ContractClass with include_str!" This reverts commit 10f9c96.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Makefile target that runs a copy of
tests/deploy_account.rswith some differences to allow for better flamegraph visualization.Note: also inverts the guard-check in this method of
InternalDeploy.