Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Move ClassHash into transaction module #1232

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Feb 7, 2024

Closes #1231

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (8f9b552) 88.97% compared to head (fe573d6) 88.97%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1232   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files          52       52           
  Lines       15604    15604           
=======================================
  Hits        13884    13884           
  Misses       1720     1720           
Files Coverage Δ
src/core/errors/state_errors.rs 50.00% <ø> (ø)
src/execution/execution_entry_point.rs 94.77% <ø> (ø)
src/execution/mod.rs 90.87% <ø> (ø)
src/lib.rs 98.23% <ø> (ø)
src/state/cached_state.rs 88.84% <ø> (ø)
src/state/contract_class_cache.rs 55.88% <ø> (ø)
src/state/contract_storage_state.rs 95.83% <ø> (ø)
src/state/in_memory_state_reader.rs 91.72% <ø> (ø)
src/state/mod.rs 95.11% <ø> (ø)
src/state/state_api.rs 100.00% <ø> (ø)
... and 14 more

@fmoletta fmoletta marked this pull request as ready for review February 7, 2024 21:22
Copy link
Contributor

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanbono juanbono added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 0436d04 Feb 7, 2024
7 checks passed
@juanbono juanbono deleted the move-class-hash-to-transaction-module branch February 7, 2024 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ClassHash type to transaction module
4 participants