This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
[0.13] Update post-execution fee checks #1204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate-block-context
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
+ Coverage 89.40% 89.65% +0.24%
==========================================
Files 50 50
Lines 14252 14304 +52
==========================================
+ Hits 12742 12824 +82
+ Misses 1510 1480 -30
|
…pdate-post-exec-tx-checks
pefontana
approved these changes
Jan 31, 2024
juanbono
approved these changes
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1193 & #1159
Changes:
run_post_execution_fee_checks
run_post_execution_fee_checks
in account txs (declare, invoke, deploy account) to run fee checks before charging the fee. This is also used to revert transactions in case of failure for revertible account transactions (invoke).Refactors:
run_post_execution_fee_checks
charge_fee
no longer calculates the actual_fee and instead receives it. This is so that account transactions (that now run fee checks before charging) don't have to calculate the fee twice