Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Fix SIR RPC get compiled class hash #1032

Merged
merged 5 commits into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rpc_state_reader/src/rpc_state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,8 @@ impl RpcState {
"params": params,
"id": 1
});
Self::deserialize_call(self.rpc_call_no_deserialize(&payload)?.into_json().unwrap())
let response = self.rpc_call_no_deserialize(&payload)?.into_json().unwrap();
Self::deserialize_call(response)
}

fn rpc_call_no_deserialize(
Expand Down
14 changes: 9 additions & 5 deletions rpc_state_reader/tests/sir_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ impl StateReader for RpcStateReader {
let nonce = self.0.get_nonce_at(&address);
Ok(Felt252::from_bytes_be(nonce.bytes()))
}

fn get_storage_at(&self, storage_entry: &StorageEntry) -> Result<Felt252, StateError> {
let (contract_address, key) = storage_entry;
let address = ContractAddress(
Expand All @@ -78,12 +79,9 @@ impl StateReader for RpcStateReader {
let value = self.0.get_storage_at(&address, &key);
Ok(Felt252::from_bytes_be(value.bytes()))
}

fn get_compiled_class_hash(&self, class_hash: &ClassHash) -> Result<[u8; 32], StateError> {
let address =
ContractAddress(PatriciaKey::try_from(StarkHash::new(*class_hash).unwrap()).unwrap());
let mut bytes = [0u8; 32];
bytes.copy_from_slice(self.0.get_class_hash_at(&address).0.bytes());
Ok(bytes)
Ok(*class_hash)
}
}

Expand Down Expand Up @@ -298,6 +296,12 @@ fn starknet_in_rust_test_case_tx(hash: &str, block_number: u64, chain: RpcChain)
}
}

#[test_case(
"0x05b4665a81d89d00e529d2e298fce6606750c4f67faf43aafc893c0fc0f9d425",
RpcChain::MainNet,
222090,
4
)]
#[test_case(
"0x01e91fa12be4424264c8cad29f481a67d5d8e23f7abf94add734d64b91c90021",
RpcChain::MainNet,
Expand Down