feat(fft): add fast mul for fft friendly fields #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLucqs
force-pushed
the
feat/fft_multiplication
branch
from
64212a2 to
efb389e
Compare
Contributor
Author
|
any opinion on where the benchmarks should live and what should be benchmarked ? @diegokingston |
0xLucqs
commented
Apr 11, 2025
0xLucqs
commented
Apr 11, 2025
pablodeymo
approved these changes
Apr 15, 2025
diegokingston
approved these changes
Apr 15, 2025
Contributor
Author
|
Anything missing to merge ? |
Collaborator
Sorry for the delay, it was a long holiday. We were looking at it and found a small comment that needs to be addressed |
MauroToscano
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the benchmark i added this multiplication algorithm is faster for polynomials of deg >= 2 ** 6.
It's most likely not how you want the benchmark to be added but didn't really find a perfect way