Skip to content

Conversation

@nicole-graus
Copy link
Contributor

Optimize Polynomial Division

Description

This PR fixes the issue #935, following its recommendation.

It optimizes the division between two polynomials by checking in the internal multiplications if there are coefficients that are equal to zero (because in those cases the coefficients do not need to be multiplied).

In the previous version a division between big degree polynomials took a minute, and now it takes less than a second.

Type of change

  • Optimization

Checklist

  • Linked to Github Issue

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.02%. Comparing base (e3debf3) to head (3046eba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   72.02%   72.02%           
=======================================
  Files         159      159           
  Lines       34892    34895    +3     
=======================================
+ Hits        25130    25133    +3     
  Misses       9762     9762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotabulacios jotabulacios marked this pull request as ready for review March 21, 2025 20:01
@jotabulacios jotabulacios requested a review from a team as a code owner March 21, 2025 20:01
@Oppen Oppen added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit bded134 Mar 21, 2025
8 checks passed
@Oppen Oppen deleted the optimize_poly_division branch March 21, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants