Remove feature serde binary for field element base type #975
+11
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
=======================================
Coverage 71.66% 71.66%
=======================================
Files 156 156
Lines 34316 34316
=======================================
Hits 24593 24593
Misses 9723 9723 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
diegokingston
approved these changes
Mar 10, 2025
Oppen
approved these changes
Mar 10, 2025
pablodeymo
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove feature serde binary for field element base type
Description
In this PR we remove the flag serde binary so that the
BaseTypeof a field element can implementByteConversionwithout that feature.