Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polynomial: differentiate & print methods. #929

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

feltroidprime
Copy link
Contributor

@feltroidprime feltroidprime commented Oct 15, 2024

Rationale :

  • differentiate can be useful

  • printing nicely the poly as well

  • Will enable drop-in replacement in Garaga for the Polynomial struct.

Thank you! :)

@feltroidprime feltroidprime requested a review from a team as a code owner October 15, 2024 10:38
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (e14cf2b) to head (cae0f12).

Files with missing lines Patch % Lines
math/src/polynomial/mod.rs 96.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
+ Coverage   71.08%   71.12%   +0.04%     
==========================================
  Files         144      144              
  Lines       31824    31880      +56     
==========================================
+ Hits        22622    22676      +54     
- Misses       9202     9204       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diegokingston diegokingston added this pull request to the merge queue Oct 23, 2024
Merged via the queue into lambdaclass:main with commit 5ad9656 Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants