Skip to content

Change ci runner #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Sep 9, 2024
Merged

Change ci runner #906

merged 20 commits into from
Sep 9, 2024

Conversation

ColoCarletti
Copy link
Contributor

Change CI runners from self-hosted to macos-latest.

@ColoCarletti ColoCarletti requested a review from a team as a code owner September 6, 2024 22:11
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.66%. Comparing base (3795dbc) to head (aab492d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
- Coverage   72.77%   72.66%   -0.12%     
==========================================
  Files         150      150              
  Lines       34196    34057     -139     
==========================================
- Hits        24886    24746     -140     
- Misses       9310     9311       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 169 to 174
- name: Install Docker
run: |
brew install docker docker-compose colima
mkdir -p ~/.docker/cli-plugins
ln -sfn /usr/local/opt/docker-compose/bin/docker-compose ~/.docker/cli-plugins/docker-compose
colima start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does any of the actions actually use Docker?

@Oppen
Copy link
Contributor

Oppen commented Sep 9, 2024

You need to install gmp and add the following to the environment for fastecdsa:

CFLAGS=-I/opt/homebrew/opt/gmp/include LDFLAGS=-L/opt/homebrew/opt/gmp/lib

Install it with brew install gmp.

@ColoCarletti ColoCarletti added this pull request to the merge queue Sep 9, 2024
@diegokingston diegokingston removed this pull request from the merge queue due to a manual request Sep 9, 2024
@ColoCarletti ColoCarletti added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit bc02f42 Sep 9, 2024
7 checks passed
@ColoCarletti ColoCarletti deleted the change_CI_runner branch September 9, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants