-
Notifications
You must be signed in to change notification settings - Fork 158
Optimize bn254 #899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Optimize bn254 #899
+717
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
==========================================
- Coverage 72.82% 72.72% -0.10%
==========================================
Files 150 150
Lines 34151 34498 +347
==========================================
+ Hits 24870 25090 +220
- Misses 9281 9408 +127 ☔ View full report in Codecov by Sentry. |
…nto optimize-bn254
math/src/elliptic_curve/short_weierstrass/curves/bn_254/field_extension.rs
Show resolved
Hide resolved
diegokingston
approved these changes
Sep 6, 2024
ColoCarletti
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BN254 optimization
Description
This PR improves the paring performance by using optimized operations used in key functions.
Also it incorporates benches for the BN254.
There is still room for improvement optimizng the Miller loop and the operations for Fp6 and Fp12
Optimized algorithms:
Line
final exponentiation
cyclotomic_square
cyclotomic_pow
Fp2 operations
Type of change
Benches
Actual
Ate pairing
: 1.6898 msMiller loop
: 540.37 µsFinal exponentiation
: 771.49 µsNew version
Ate pairing
:939.71 µsMiller loop
: 375.96 µsFinal exponentiation
: 347.71 µs