Bn254 pairing #889
Merged
Bn254 pairing #889
+961
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
+ Coverage 72.07% 72.80% +0.72%
==========================================
Files 149 150 +1
Lines 33427 34119 +692
==========================================
+ Hits 24092 24839 +747
+ Misses 9335 9280 -55 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| #[test] | ||
| fn g2_conjugate_two_times_is_identity() { |
There was a problem hiding this comment.
I think this test is trivial. We should try non-zero elements
Oppen
reviewed
Aug 15, 2024
| } | ||
|
|
||
| /// Computes the line between q and t and evaluates it in p. | ||
| /// Algorithm adapted from Arkowork's double_in_place and add_in_place. |
There was a problem hiding this comment.
Suggested change
| /// Algorithm adapted from Arkowork's double_in_place and add_in_place. | |
| /// Algorithm adapted from Arkwork's double_in_place and add_in_place. |
Oppen
approved these changes
Aug 15, 2024
diegokingston
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BN254 Pairing
Description
Implementation of BN254 elliptic curve Ate pairing
Type of change