fix: unaligned read for Metal buffers #882
Merged
+11
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: unaligned read on Metal implementation
After Rust 1.77
u128
starts requiring 16 bytes aligned values. Thisbreaks Metal, where
retrieve_contents
assumed it could just cast thepointer and treat it as a slice.
Instead, we need to assume no alignment by doing the following:
i-th
element from the buffer withptr.add(i).read_unaligned()
;clone
the read value, as the bitwise copy may cause aliasingotherwise;
push
theclone
d value into the vector;mem::forget
the element we read to avoid calling itsdrop
implementation twice, one for the copy and one for the
Buffer
.Type of change