Skip to content

Add error to UnsInt from_hex when hex too big #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 17, 2024

Conversation

MauroToscano
Copy link
Collaborator

Fix panic on from_hex with big strings

Type of change

Please delete options that are not relevant.

  • Bug fix

Checklist

  • Linked to Github Issue

@MauroToscano MauroToscano requested a review from a team as a code owner July 16, 2024 16:27
@MauroToscano MauroToscano marked this pull request as draft July 16, 2024 16:27
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.02%. Comparing base (dfe4f0e) to head (507ac76).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
+ Coverage   72.01%   72.02%   +0.01%     
==========================================
  Files         149      149              
  Lines       33377    33407      +30     
==========================================
+ Hits        24036    24062      +26     
- Misses       9341     9345       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@entropidelic entropidelic marked this pull request as ready for review July 16, 2024 20:23
@MauroToscano MauroToscano added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 712d894 Jul 17, 2024
6 of 7 checks passed
@MauroToscano MauroToscano deleted the fix_big_hexstring_err branch July 17, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants