Add big uint conversion #1002
Merged
Add big uint conversion #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1002 +/- ##
==========================================
+ Coverage 72.06% 72.17% +0.10%
==========================================
Files 160 160
Lines 35145 35268 +123
==========================================
+ Hits 25327 25453 +126
+ Misses 9818 9815 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…aworks into add_BigUint_conversion
…aworks into add_BigUint_conversion
pablodeymo
reviewed
May 6, 2025
crates/math/src/field/element.rs
Outdated
| let mut bytes = value.to_bytes_le(); | ||
| // We pad the bytes to the size of the base type to be able to apply `from_bytes_le`. | ||
| bytes.resize(core::mem::size_of::<F::BaseType>(), 0); | ||
| Ok(Self::from_bytes_le(&bytes).unwrap()) |
Contributor
There was a problem hiding this comment.
the unwrap is note necessary and the Ok as well
pablodeymo
approved these changes
May 8, 2025
diegokingston
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add BigUint conversion
Description
This PR adds
try_fromoperator to create a field element from aBigUintType of change
Please delete options that are not relevant.
Checklist