refactor: merge metrics with PromEx #1242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were using two Prometheus clients (prometheus_ex and telemetry_metrics_prometheus).
Description
Merge our BEAM and custom metrics using PromEx:
PromExmodule to start a standalone HTTP server to serve the aggregated metrics .prometheus_ex,telemetry_metrics_prometheusand their dependencies.PromEx.Beamplugin, which captures metrics regarding the Erlang Virtual Machine.nodedashboard.--metricsand--metrics-portflags to have the same logic as the beacon-api flags.As a result, it is no longer necessary to start the
BeaconApito see the BEAM metrics. They are all aggregated in the PromEx server.Closes #903