-
Notifications
You must be signed in to change notification settings - Fork 120
chore(l1): renaming to remove metrics_ prefix from file names
#5385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lines of code reportTotal lines added: Detailed view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the unnecessary metrics_ prefix from metric module file names now that they reside in a dedicated /metrics folder, improving code organization and clarity.
Key changes:
- Renamed three core metric modules:
metrics_blocks→blocks,metrics_transactions→transactions,metrics_process→process - Updated all import statements across the codebase to reference the new module names
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/blockchain/metrics/mod.rs | Updated module declarations to remove metrics_ prefix |
| crates/blockchain/metrics/api.rs | Updated imports to use new module names |
| crates/blockchain/metrics/blocks.rs | Renamed file (content appears to be moved from metrics_blocks.rs) |
| crates/blockchain/metrics/transactions.rs | Renamed file (content appears to be moved from metrics_transactions.rs) |
| crates/blockchain/metrics/process.rs | Renamed file (content appears to be moved from metrics_process.rs) |
| crates/blockchain/payload.rs | Updated imports to use new module names |
| crates/blockchain/blockchain.rs | Updated imports to use new module names |
| crates/blockchain/fork_choice.rs | Updated imports to use new module names |
| crates/l2/sequencer/metrics.rs | Updated imports to use new module names |
| crates/l2/sequencer/block_producer.rs | Updated imports to use new module names |
| crates/l2/sequencer/block_producer/payload_builder.rs | Updated imports to use new module names |
| cmd/ethrex/initializers.rs | Updated imports to use new module names |
Comments suppressed due to low confidence (1)
crates/blockchain/metrics/mod.rs:42
- The documentation comment contains an outdated example that still references
metrics_transactions. This should be updated totransactionsto reflect the module rename.
// use ethrex_metrics::metrics_transactions::{METRICS_TX};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
metrics_ suffix to file namesmetrics_ prefix to file names
metrics_ prefix to file namesmetrics_ prefix from file names
Motivation
This was needed before when we didn't had a
/metricsfolder, now the prefix is unnecessaryDescription
remove unnecessary
metrics_prefix from metric modulesCloses #5378