-
Notifications
You must be signed in to change notification settings - Fork 120
perf(l1): cache account_codes blobs #5366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lines of code reportTotal lines added: Detailed view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds explicit blob cache configuration to improve performance for the account_codes column family in RocksDB. Moving to BlobDB previously disabled implicit caching, so this change configures a 128MB LRU cache specifically for blob data.
- Configures explicit 128MB LRU cache for blob files in the account_codes column family
- Addresses performance regression from BlobDB migration by re-enabling caching
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Benchmark Block Execution Results Comparison Against Main
|
|
Closed in favor of #5307 |
Motivation
Moving to BlobDB improved performance, but we suspect this also disabled caching for values.
Description
This PR configures an explicit blob cache of 128MB.
Flamegraph before:
Flamegraph after:
Notice
TableCache::Getin the far left getting bigger than before. We also get a lot less decompression.