Merged
Conversation
lferrigno
referenced
this pull request
in lferrigno/ethrex
Jan 18, 2026
…rks (#5) Implement fork-specific gas cost handling for the SSTORE opcode across pre-merge Ethereum forks. This completes the core gas cost implementation for pre-merge fork support. Changes to gas_cost.rs: - Add pre-Istanbul SSTORE constants: SSTORE_GAS_SET (20000 for zero to non-zero), SSTORE_GAS_RESET (5000 for other changes), and SSTORE_REFUND_CLEAR (15000 for clearing slots) - Modify sstore() to accept fork parameter and use simple gas model for pre-Istanbul forks (no net gas metering) - Apply EIP-2929 cold/warm access costs only for Berlin and later Changes to stack_memory_storage_flow.rs: - Pass fork to gas_cost::sstore() function - Apply EIP-2200 stipend check only for Istanbul and later forks - Implement pre-Istanbul refund logic: 15000 gas refund for clearing storage (non-zero to zero) - Maintain EIP-2200 net gas metering refunds for Istanbul+ forks Gas cost history for SSTORE: - Frontier through Spurious Dragon: 20000 (set), 5000 (reset), 15000 refund - Istanbul: EIP-2200 net gas metering - Berlin+: EIP-2929 cold/warm access costs added
edg-l
added a commit
that referenced
this pull request
Feb 2, 2026
Per EIP-7928, coinbase must appear in BAL when there's a user transaction, even if the priority fee is zero. System contract calls have gas_price = 0, so we use this to distinguish them from user transactions.
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We want to have the minimal endpoints to connect to a consensus client