-
Notifications
You must be signed in to change notification settings - Fork 64
feat(l1): drop unwraps from rpc crate #3075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Lines of code reportTotal lines added: Detailed view
|
let response = | ||
self.client | ||
.get(self.url.clone().join(endpoint).map_err(|_| { | ||
BeaconClientError::Custom("Failed to set url endpoint".to_string()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be add a new error type ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
Dissallow unwraps on l1.
Description
This pr drops unwraps on crate rpc in networking. Test's unwraps remain. Resolves partially #2879