-
Notifications
You must be signed in to change notification settings - Fork 91
chore(l1): drop unwraps from p2p crate #3051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lines of code reportTotal lines added: Detailed view
|
Co-authored-by: Marcos Nicolau <76252340+MarcosNicolau@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I highlighted all the potential refactoring opportunities in comments. In future PRs I suggest you to review your own code once you made it work, and figure out if there isn't a refactoring opportunity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I just have some doubts about the errors used in some cases
Motivation
Dissallow unwraps on l1.
Description
This pr drops unwraps on crate p2p in networking. Test's unwraps remain. Resolves partially #2879