feat: Validium mode #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toni-calvin
force-pushed
the
validium_mode
branch
from
0357e20
to
7fe7979
Compare
* Set and to 0 in * Set to 0 in * change pubdata constants to 0 * Comment revert * Comment check on operator overhead --------- Co-authored-by: Ivan Litteri <ivanlitteri@Ivans-MacBook-Pro.local>
Deniallugo
reviewed
Jan 16, 2024
| @@ -90,7 +91,8 @@ uint256 constant BATCH_OVERHEAD_L2_GAS = $(BATCH_OVERHEAD_L2_GAS); | |||
| uint256 constant BATCH_OVERHEAD_L1_GAS = $(BATCH_OVERHEAD_L1_GAS); | |||
|
|
|||
| /// @dev The equivalent in L1 pubdata of L1 gas used for working with L1 | |||
| uint256 constant BATCH_OVERHEAD_PUBDATA = BATCH_OVERHEAD_L1_GAS / L1_GAS_PER_PUBDATA_BYTE; | |||
| // uint256 constant BATCH_OVERHEAD_PUBDATA = BATCH_OVERHEAD_L1_GAS / L1_GAS_PER_PUBDATA_BYTE; | |||
| uint256 constant BATCH_OVERHEAD_PUBDATA = 0; | |||
There was a problem hiding this comment.
I'm not sure it's correct, because we still store some data.
There was a problem hiding this comment.
This was set to 0 because of the 0 division, what should we set it to? Can you elaborate more on what data are we still storing?
| @@ -364,7 +370,7 @@ contract ExecutorFacet is Base, IExecutor { | |||
|
|
|||
| function _verifyProof(uint256[] memory proofPublicInput, ProofInput calldata _proof) internal view { | |||
| // We can only process 1 batch proof at a time. | |||
| require(proofPublicInput.length == 1, "t4"); | |||
| require(_proof.serializedProof.length == 1, "t4"); | |||
There was a problem hiding this comment.
We can change it and check that the results are still the same
|
Superseded by #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist