Nonce address fix #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 4, 2024
…er-bugs [EVM-Equivalence-YUL] Fix compiler tester bugs
|
Hey @gianbelinche - who is supposed to review it? |
This removes a lot of unneeded spills and reloads generated by the compiler. Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
Signed-off-by: Vladimir Radosavljevic <vr@matterlabs.dev>
Hey, yeah we'll make the PR to matter-labs now, we were reviewing a few things before doing so |
…ivalence-yul-optimizations [EVM-Equivalence-YUL] Optimize opcodes
…nly-for-eoas-on-failure [EVM Equivalence Yul] Increment nonce on failed deployments only for eoas
|
Closing as this change was merged here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR fixes some tests on era-compiler-tester that expected the nonce on EVM to start at 1, while we start it at 0.
It depends on lambdaclass/era-compiler-tester#1
Why ❔
Checklist