Skip to content
L1 contracts CI

Remove asserts from bootloader #48

Sign in to view logs

Remove asserts from bootloader

Remove asserts from bootloader #48

Triggered via pull request August 20, 2024 13:56
@gianbelinchegianbelinche
opened #26
evm-integration-tests-new
Status Failure
Total duration 5m 25s
Artifacts –

l1-contracts-ci.yaml

on: pull_request
build
3m 30s
build
lint
52s
lint
check-verifier-generator
5m 10s
check-verifier-generator
test-foundry
0s
test-foundry
test-hardhat
0s
test-hardhat
coverage
0s
coverage
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 10 warnings
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L26
Error message for require is too long: 40 counted / 32 allowed
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L26
GC: Use Custom Errors instead of require statements
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L53
GC: Use Custom Errors instead of require statements
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L54
GC: Found [ .length ] property in Loop condition. Suggestion: assign it to a variable
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L72
Error message for require is too long: 55 counted / 32 allowed
lint: l1-contracts/contracts/governance/ChainAdmin.sol#L72
GC: Use Custom Errors instead of require statements
lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L20
Provide an error message for require
lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L20
GC: Use Custom Errors instead of require statements
lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L21
Provide an error message for require
lint: l1-contracts/deploy-scripts/DecentralizeGovernanceUpgradeScript.s.sol#L21
GC: Use Custom Errors instead of require statements
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: l2-contracts/contracts/SystemContractsCaller.sol#L3
Found more than One contract per file. 2 contracts found!
lint: system-contracts/contracts/ContractDeployer.sol#L192
Avoid to use tx.origin
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache/save@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
check-verifier-generator
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check-verifier-generator
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check-verifier-generator
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/