Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make benches/libfuncs.rs also run AOT benches #868

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Oct 18, 2024

Fixes #867

Copy link

github-actions bot commented Oct 18, 2024

✅ Code is now correctly formatted.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.83%. Comparing base (4ba9e16) to head (bb4c370).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #868   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files         120      120           
  Lines       35148    35148           
=======================================
  Hits        29114    29114           
  Misses       6034     6034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 18, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.030 ± 0.287 10.748 11.508 23.47 ± 0.61
cairo-native (embedded AOT) 3.170 ± 0.034 3.116 3.239 6.75 ± 0.07
cairo-native (embedded JIT using LLVM's ORC Engine) 3.286 ± 0.026 3.239 3.313 6.99 ± 0.06
cairo-native (standalone AOT) 0.680 ± 0.001 0.678 0.681 1.45 ± 0.00
cairo-native (standalone AOT with -march=native) 0.470 ± 0.000 0.469 0.471 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.152 ± 0.267 10.617 11.409 1382.18 ± 80.46
cairo-native (embedded AOT) 2.700 ± 0.027 2.661 2.754 334.59 ± 18.06
cairo-native (embedded JIT using LLVM's ORC Engine) 2.741 ± 0.020 2.709 2.776 339.71 ± 18.19
cairo-native (standalone AOT) 0.009 ± 0.000 0.009 0.009 1.07 ± 0.06
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.013 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.328 ± 0.021 4.280 4.351 59.73 ± 0.32
cairo-native (embedded AOT) 2.868 ± 0.016 2.840 2.897 39.58 ± 0.24
cairo-native (embedded JIT using LLVM's ORC Engine) 3.066 ± 0.022 3.033 3.100 42.32 ± 0.32
cairo-native (standalone AOT) 0.112 ± 0.000 0.112 0.113 1.55 ± 0.00
cairo-native (standalone AOT with -march=native) 0.072 ± 0.000 0.072 0.073 1.00

Copy link

github-actions bot commented Oct 18, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.171 ± 0.017 3.151 3.195 1.01 ± 0.01
base factorial_2M.cairo (JIT) 3.175 ± 0.013 3.152 3.192 1.01 ± 0.01
head factorial_2M.cairo (AOT) 3.142 ± 0.023 3.113 3.191 1.00
base factorial_2M.cairo (AOT) 3.146 ± 0.023 3.121 3.190 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.692 ± 0.018 2.666 2.719 1.01 ± 0.01
base fib_2M.cairo (JIT) 2.685 ± 0.011 2.671 2.703 1.01 ± 0.01
head fib_2M.cairo (AOT) 2.662 ± 0.031 2.626 2.716 1.00
base fib_2M.cairo (AOT) 2.670 ± 0.015 2.647 2.696 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 2.997 ± 0.017 2.978 3.022 1.07 ± 0.01
base logistic_map.cairo (JIT) 2.971 ± 0.014 2.953 2.999 1.06 ± 0.01
head logistic_map.cairo (AOT) 2.818 ± 0.021 2.779 2.846 1.00 ± 0.01
base logistic_map.cairo (AOT) 2.813 ± 0.018 2.769 2.833 1.00

@edg-l edg-l marked this pull request as ready for review October 21, 2024 07:30
@edg-l edg-l changed the title bench improvement make benches/libfuncs.rs also run AOT benches Oct 21, 2024
@edg-l edg-l added the review-ready A PR that is ready for review label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

benches/libfuncs.rs should also run AOT benches
2 participants