Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored u16 to use the BlockExt trait #668

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

tcoratger
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

fmoletta
fmoletta previously approved these changes Jun 4, 2024
juanbono
juanbono previously approved these changes Jun 4, 2024
@juanbono juanbono enabled auto-merge June 4, 2024 21:17
@juanbono juanbono added this pull request to the merge queue Jun 4, 2024
auto-merge was automatically disabled June 4, 2024 21:54

Head branch was pushed to by a user without write access

@tcoratger tcoratger dismissed stale reviews from juanbono and fmoletta via 66e8d4a June 4, 2024 21:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.72727% with 12 lines in your changes missing coverage. Please review.

Project coverage is 91.61%. Comparing base (b2f1568) to head (afebc44).
Report is 11 commits behind head on main.

Current head afebc44 differs from pull request most recent head 66e8d4a

Please upload reports for the commit 66e8d4a to get more accurate results.

Files Patch % Lines
src/libfuncs/uint16.rs 92.72% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
- Coverage   91.95%   91.61%   -0.35%     
==========================================
  Files         112      115       +3     
  Lines       34265    34554     +289     
==========================================
+ Hits        31509    31656     +147     
- Misses       2756     2898     +142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into lambdaclass:main with commit 26b0ecc Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants