Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate run in tests::common::run_native_program #659

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

fmoletta
Copy link
Member

@fmoletta fmoletta commented Jun 4, 2024

The same block of code is executed twice

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@fmoletta fmoletta marked this pull request as ready for review June 4, 2024 20:11
Copy link

github-actions bot commented Jun 4, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.252 ± 0.063 11.182 11.379 23.44 ± 0.13
cairo-native (embedded AOT) 1.490 ± 0.010 1.474 1.511 3.10 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 1.576 ± 0.009 1.567 1.590 3.28 ± 0.02
cairo-native (standalone AOT) 0.653 ± 0.004 0.651 0.665 1.36 ± 0.01
cairo-native (standalone AOT with -march=native) 0.480 ± 0.000 0.479 0.481 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.554 ± 0.077 10.485 10.762 1301.13 ± 17.43
cairo-native (embedded AOT) 1.075 ± 0.006 1.068 1.083 132.58 ± 1.64
cairo-native (embedded JIT using LLVM's ORC Engine) 1.082 ± 0.006 1.074 1.097 133.36 ± 1.69
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.04 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.860 ± 0.011 1.846 1.880 28.14 ± 0.18
cairo-native (embedded AOT) 1.219 ± 0.005 1.211 1.231 18.45 ± 0.09
cairo-native (embedded JIT using LLVM's ORC Engine) 1.392 ± 0.011 1.384 1.423 21.07 ± 0.18
cairo-native (standalone AOT) 0.107 ± 0.000 0.107 0.107 1.62 ± 0.00
cairo-native (standalone AOT with -march=native) 0.066 ± 0.000 0.066 0.067 1.00

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (eacacf7) to head (d420deb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #659   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files         115      115           
  Lines       34254    34254           
=======================================
  Hits        31455    31455           
  Misses       2799     2799           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanbono juanbono added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 0cf27e0 Jun 5, 2024
9 checks passed
@juanbono juanbono deleted the remove-duplicate-run-in-test branch June 5, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants