Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test syscall handler secp operations #641

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jun 3, 2024

This is a fix extracted from #622 but without the corelib yet, since i still need to investigate the corelib issues, but this is ready to merge

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

azteca1998
azteca1998 previously approved these changes Jun 3, 2024
@juanbono juanbono enabled auto-merge June 3, 2024 13:42
Copy link

github-actions bot commented Jun 3, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.338 ± 0.077 11.232 11.458 23.61 ± 0.16
cairo-native (embedded AOT) 1.518 ± 0.010 1.499 1.531 3.16 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 1.624 ± 0.022 1.598 1.661 3.38 ± 0.05
cairo-native (standalone AOT) 0.655 ± 0.006 0.651 0.666 1.36 ± 0.01
cairo-native (standalone AOT with -march=native) 0.480 ± 0.001 0.479 0.481 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.644 ± 0.048 10.563 10.710 1304.48 ± 17.84
cairo-native (embedded AOT) 1.130 ± 0.026 1.099 1.193 138.45 ± 3.61
cairo-native (embedded JIT using LLVM's ORC Engine) 1.136 ± 0.016 1.115 1.160 139.16 ± 2.67
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.04 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.940 ± 0.019 1.909 1.958 29.25 ± 0.29
cairo-native (embedded AOT) 1.272 ± 0.024 1.251 1.326 19.18 ± 0.36
cairo-native (embedded JIT using LLVM's ORC Engine) 1.449 ± 0.011 1.430 1.470 21.85 ± 0.17
cairo-native (standalone AOT) 0.107 ± 0.000 0.107 0.107 1.62 ± 0.00
cairo-native (standalone AOT with -march=native) 0.066 ± 0.000 0.066 0.067 1.00

@juanbono juanbono added this pull request to the merge queue Jun 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (1e850c9) to head (cc17acc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   91.95%   91.95%   -0.01%     
==========================================
  Files         112      112              
  Lines       34266    34265       -1     
==========================================
- Hits        31510    31509       -1     
  Misses       2756     2756              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l added the review-ready A PR that is ready for review label Jun 3, 2024
Merged via the queue into main with commit b2f1568 Jun 3, 2024
9 checks passed
@juanbono juanbono deleted the fix_syscallhandler_test branch June 3, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants