Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply missed fixes on llvm 18 pr #620

Merged
merged 3 commits into from
May 23, 2024
Merged

Apply missed fixes on llvm 18 pr #620

merged 3 commits into from
May 23, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented May 23, 2024

Applies the comments from #566 (review)

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@edg-l edg-l added priority review-ready A PR that is ready for review labels May 23, 2024
Copy link

github-actions bot commented May 23, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.419 ± 0.082 11.315 11.607 23.78 ± 0.17
cairo-native (embedded AOT) 1.568 ± 0.014 1.545 1.592 3.27 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 1.637 ± 0.020 1.609 1.679 3.41 ± 0.04
cairo-native (standalone AOT) 0.653 ± 0.004 0.651 0.662 1.36 ± 0.01
cairo-native (standalone AOT with -march=native) 0.480 ± 0.001 0.479 0.481 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.671 ± 0.026 10.624 10.694 1314.73 ± 14.67
cairo-native (embedded AOT) 1.112 ± 0.006 1.103 1.124 136.98 ± 1.66
cairo-native (embedded JIT using LLVM's ORC Engine) 1.124 ± 0.009 1.114 1.147 138.43 ± 1.88
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.04 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.008 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.893 ± 0.012 1.876 1.915 28.65 ± 0.19
cairo-native (embedded AOT) 1.253 ± 0.006 1.243 1.262 18.97 ± 0.10
cairo-native (embedded JIT using LLVM's ORC Engine) 1.425 ± 0.007 1.416 1.436 21.57 ± 0.11
cairo-native (standalone AOT) 0.107 ± 0.000 0.107 0.107 1.62 ± 0.00
cairo-native (standalone AOT with -march=native) 0.066 ± 0.000 0.066 0.066 1.00

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (4273c9f) to head (06b9b72).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files         109      109           
  Lines       34097    34097           
=======================================
  Hits        31485    31485           
  Misses       2612     2612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l mentioned this pull request May 23, 2024
5 tasks
@edg-l edg-l added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit cd75446 May 23, 2024
9 checks passed
@edg-l edg-l deleted the some_fixes branch May 23, 2024 14:22
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 26, 2024
* apply missed fixes

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants