Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SquashedFelt252Dict in executor #611

Merged
merged 3 commits into from
May 22, 2024

Conversation

tcoratger
Copy link
Collaborator

Should close #601.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@tcoratger tcoratger marked this pull request as ready for review May 20, 2024 11:42
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 91.41%. Comparing base (b09410b) to head (4f28173).

Files Patch % Lines
src/executor.rs 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   91.42%   91.41%   -0.01%     
==========================================
  Files         109      109              
  Lines       35881    35891      +10     
==========================================
+ Hits        32803    32811       +8     
- Misses       3078     3080       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanbono
Copy link
Member

great PR! I'll take a look in a moment

@juanbono juanbono added the review-ready A PR that is ready for review label May 20, 2024
@edg-l edg-l added this pull request to the merge queue May 22, 2024
Merged via the queue into lambdaclass:main with commit ad8529d May 22, 2024
9 checks passed
Gerson2102 pushed a commit to Gerson2102/cairo_native that referenced this pull request May 26, 2024
* add SquashedFelt252Dict in executor

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement CoreTypeConcrete::SquashedFelt252Dict return type
5 participants