-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integer casting #605
Merged
Merged
Fix integer casting #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.577 ± 0.174 | 11.395 | 11.970 | 24.06 ± 0.36 |
cairo-native (embedded AOT) |
1.566 ± 0.016 | 1.534 | 1.589 | 3.25 ± 0.03 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.698 ± 0.067 | 1.650 | 1.883 | 3.53 ± 0.14 |
cairo-native (standalone AOT) |
0.653 ± 0.002 | 0.651 | 0.655 | 1.36 ± 0.00 |
cairo-native (standalone AOT with -march=native) |
0.481 ± 0.001 | 0.480 | 0.483 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.754 ± 0.060 | 10.680 | 10.829 | 1313.66 ± 16.61 |
cairo-native (embedded AOT) |
1.122 ± 0.010 | 1.106 | 1.142 | 136.99 ± 1.96 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.168 ± 0.019 | 1.139 | 1.192 | 142.62 ± 2.83 |
cairo-native (standalone AOT) |
0.009 ± 0.000 | 0.008 | 0.009 | 1.04 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.958 ± 0.027 | 1.922 | 2.004 | 29.48 ± 0.44 |
cairo-native (embedded AOT) |
1.298 ± 0.021 | 1.264 | 1.330 | 19.54 ± 0.34 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.502 ± 0.019 | 1.464 | 1.527 | 22.62 ± 0.32 |
cairo-native (standalone AOT) |
0.107 ± 0.000 | 0.107 | 0.108 | 1.61 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.066 ± 0.000 | 0.066 | 0.068 | 1.00 |
JulianGCalderon
force-pushed
the
fix-integer-tests
branch
from
May 17, 2024 15:22
85fbd71
to
af38e51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 109 109
Lines 34099 34101 +2
=======================================
+ Hits 31485 31488 +3
+ Misses 2614 2613 -1 ☔ View full report in Codecov by Sentry. |
JulianGCalderon
requested review from
edg-l,
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
May 20, 2024 14:42
edg-l
approved these changes
May 20, 2024
azteca1998
approved these changes
May 22, 2024
Gerson2102
pushed a commit
to Gerson2102/cairo_native
that referenced
this pull request
May 26, 2024
* Separate variables for better legibility * Fix proper_cast test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #604
Checklist
Fixes